Crabs/3DChess
2
1
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

refactor misc

Browse Source
This commit is contained in:
Simon Pribylski
2025-05-03 20:49:03 +02:00
parent b18b53f195
commit a595b62fca
3 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/main/java/chess/ai/DumbAI.java
View File

@@ -31,7 +31,7 @@ public class DumbAI extends AI {
int randomMove = this.random.nextInt(moves.size() + 2); int randomMove = this.random.nextInt(moves.size() + 2);
if (randomMove < moves.size() - 2) if (randomMove < moves.size() - 2)
break; break;
this.commandExecutor.executeCommand(new CastlingCommand(randomMove == moves.size())); sendCommand(new CastlingCommand(randomMove == moves.size()));
return; return;
} }
@@ -40,7 +40,7 @@ public class DumbAI extends AI {
int randomMove = this.random.nextInt(moves.size() + 1); int randomMove = this.random.nextInt(moves.size() + 1);
if (randomMove != moves.size()) if (randomMove != moves.size())
break; break;
this.commandExecutor.executeCommand(new CastlingCommand(castlings == CastlingResult.Big)); sendCommand(new CastlingCommand(castlings == CastlingResult.Big));
return; return;
} }
@@ -49,13 +49,13 @@ public class DumbAI extends AI {
} }
int randomMove = this.random.nextInt(moves.size()); int randomMove = this.random.nextInt(moves.size());
this.commandExecutor.executeCommand(new MoveCommand(moves.get(randomMove))); sendCommand(new MoveCommand(moves.get(randomMove)));
} }
@Override @Override
protected void promote(Coordinate pawnCoords) { protected void promote(Coordinate pawnCoords) {
int promote = this.random.nextInt(PromoteType.values().length); int promote = this.random.nextInt(PromoteType.values().length);
this.commandExecutor.executeCommand(new PromoteCommand(PromoteType.values()[promote])); sendCommand(new PromoteCommand(PromoteType.values()[promote]));
} }
} }

1
app/src/main/java/chess/controller/commands/PromoteCommand.java
View File

@@ -28,6 +28,7 @@ public class PromoteCommand extends PlayerCommand {
public PromoteCommand(PromoteType promoteType) { public PromoteCommand(PromoteType promoteType) {
this.promoteType = promoteType; this.promoteType = promoteType;
assert this.promoteType != null;
this.pieceCoords = null; this.pieceCoords = null;
this.oldPawn = null; this.oldPawn = null;
} }

5
app/src/test/java/chess/AppTest.java
View File

@@ -15,7 +15,7 @@ import chess.model.Color;
import chess.model.Game; import chess.model.Game;
class AppTest { class AppTest {
@Test void functionalRollback(){ private void functionalRollback(){
Game game = new Game(); Game game = new Game();
CommandExecutor commandExecutor = new CommandExecutor(game); CommandExecutor commandExecutor = new CommandExecutor(game);
@@ -38,6 +38,9 @@ class AppTest {
CommandExecutor initialCommandExecutor = new CommandExecutor(initialGame); CommandExecutor initialCommandExecutor = new CommandExecutor(initialGame);
initialCommandExecutor.executeCommand(new NewGameCommand()); initialCommandExecutor.executeCommand(new NewGameCommand());
initialCommandExecutor.close();
commandExecutor.close();
assert(game.getBoard().equals(initialGame.getBoard())); assert(game.getBoard().equals(initialGame.getBoard()));
} }