Blitz/Blitz
3
1
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects 1 Releases 2 Wiki Activity

firingrate #33

Merged
Persson-dev merged 11 commits from firingrate into main 2024-04-02 20:25:48 +00:00
Conversation 3 Commits 11 Files Changed 27 +182 -34
Morph01 commented 2024-04-02 07:52:19 +00:00
Owner
Copy Link

ajout d'un changement pour la cadence de tir

ajout d'un changement pour la cadence de tir
Morph01 added 2 commits 2024-04-02 07:52:19 +00:00
Fix mouse sensitivity range in OptionsMenu ce964294f4
Add ShootTimer to ServerConfig
All checks were successful
Linux arm64 / Build (push) Successful in 5m20s
Details
08e3463c70
Persson-dev requested changes 2024-04-02 07:54:43 +00:00
Dismissed
Persson-dev left a comment
Owner
Copy Link

Tu ne mets pas à jour correctement le cooldown du timer

Tu ne mets pas à jour correctement le cooldown du timer
src/client/display/PlayerController.cpp Outdated
@@ -68,3 +67,3 @@
}
bool canShoot = m_ShootTimer.Update(delta);
bool canShoot = m_ShootTimer.Update(m_Client->GetConfig()->GetServerConfigShootTimer());
Persson-dev commented 2024-04-02 07:52:56 +00:00
Owner
Copy Link

il faut update avec le delta

il faut update avec le delta
Morph01 marked this conversation as resolved
src/client/gui/OptionsMenu.cpp
@@ -169,3 +169,3 @@
float sensitivity = m_Client->GetConfig()->GetMouseSpeed() * 200.0f;
ImGui::SetNextItemWidth(300.0f);
if (ImGui::DragFloat("Sensibilite", &sensitivity, 0.005f, 0.0f, 10.0f, "%.3f")) {
if (ImGui::DragFloat("Sensibilite", &sensitivity, 0.005f, 0.001f, 10.0f, "%.3f")) {
Persson-dev commented 2024-04-02 07:53:18 +00:00
Owner
Copy Link

tu peux utiliser std::clamp

tu peux utiliser std::clamp
Persson-dev marked this conversation as resolved
src/client/gui/ServerGui.cpp Outdated
@@ -69,0 +72,4 @@
ImGui::SetNextItemWidth(300.0f);
if (ImGui::DragInt("##CADENCE TIR", &shoottimer, 1, 1, 100)) {
if (shoottimer < 0)
shoottimer = 1;
Persson-dev commented 2024-04-02 07:53:43 +00:00
Owner
Copy Link

là aussi clamp

là aussi clamp
Persson-dev marked this conversation as resolved
Persson-dev added 1 commit 2024-04-02 08:32:54 +00:00
move config in Game.h
All checks were successful
Linux arm64 / Build (push) Successful in 4m44s
Details
82b0ede933
Morph01 added 1 commit 2024-04-02 09:18:24 +00:00
Refactor shooting rate configuration and better clamp
Some checks failed
Linux arm64 / Build (push) Failing after 4m26s
Details
64f8ceb964
Persson-dev requested review from Persson-dev 2024-04-02 09:20:03 +00:00
Persson-dev approved these changes 2024-04-02 09:20:20 +00:00
Morph01 added 1 commit 2024-04-02 09:34:04 +00:00
Fix firing rate data type in GameConfig struct
All checks were successful
Linux arm64 / Build (push) Successful in 4m58s
Details
9e46b92687
Morph01 added 1 commit 2024-04-02 18:40:08 +00:00
Add ServerConfig et and implement SendServerConfigmethods
All checks were successful
Linux arm64 / Build (push) Successful in 5m3s
Details
e121a092b2
Persson-dev added 1 commit 2024-04-02 19:31:17 +00:00
update game config on client
Some checks failed
Linux arm64 / Build (push) Failing after 3m24s
Details
7cb9c0d280
Persson-dev commented 2024-04-02 19:32:39 +00:00
Owner
Copy Link

Fix #32

Fix #32
Persson-dev added 2 commits 2024-04-02 19:51:24 +00:00
fix json saving 716cd46280
set gun animation speed relative to firerate
Some checks failed
Linux arm64 / Build (push) Failing after 3m20s
Details
8bb224ec5f
Persson-dev added 1 commit 2024-04-02 19:58:29 +00:00
fix build
All checks were successful
Linux arm64 / Build (push) Successful in 5m12s
Details
482fc5d702
Persson-dev added 1 commit 2024-04-02 20:13:45 +00:00
reset fire cooldown on firerate change
All checks were successful
Linux arm64 / Build (push) Successful in 6m47s
Details
30e187ce4e
Persson-dev merged commit a7b235da38 into main 2024-04-02 20:25:48 +00:00
Persson-dev deleted branch firingrate 2024-04-02 20:25:48 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Persson-dev
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
AquaEBM Morph01 Persson-dev
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Blitz/Blitz#33
Delete Branch "firingrate"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?