refactor: use of unique_ptr instead of new

This commit is contained in:
2021-11-06 13:02:53 +01:00
parent 26290d8332
commit 6825a6327f
19 changed files with 136 additions and 134 deletions

View File

@@ -107,7 +107,7 @@ void Server::updateSockets() {
}
}
void Server::broadcastPacket(protocol::Packet* packet) {
void Server::broadcastPacket(const protocol::Packet* packet) {
for (auto& connection : m_Connections) {
ServerConnexion& con = connection.second;
con.sendPacket(packet);

View File

@@ -72,7 +72,7 @@ void ServerConnexion::sendKeepAlive() {
m_KeepAlive.sendTime = time;
}
void ServerConnexion::HandlePacket(protocol::PlayerLoginPacket* packet) {
void ServerConnexion::HandlePacket(const protocol::PlayerLoginPacket* packet) {
if (m_Player->getName().empty() && !packet->getPlayerName().empty()) {
m_Player->setName(packet->getPlayerName());
@@ -95,7 +95,7 @@ void ServerConnexion::HandlePacket(protocol::PlayerLoginPacket* packet) {
}
}
void ServerConnexion::HandlePacket(protocol::SelectTeamPacket* packet) {
void ServerConnexion::HandlePacket(const protocol::SelectTeamPacket* packet) {
if (m_Server->getGame().getGameState() != game::GameState::Lobby)
return;
if ((std::int8_t)packet->getSelectedTeam() >= -1 || (std::int8_t)packet->getSelectedTeam() <= 1) {
@@ -114,12 +114,12 @@ void ServerConnexion::HandlePacket(protocol::SelectTeamPacket* packet) {
}
}
void ServerConnexion::HandlePacket(protocol::KeepAlivePacket* packet) {
void ServerConnexion::HandlePacket(const protocol::KeepAlivePacket* packet) {
if (packet->getAliveID() == m_KeepAlive.keepAliveID)
m_KeepAlive.recievedResponse = true;
}
void ServerConnexion::HandlePacket(protocol::DisconnectPacket* packet) {
void ServerConnexion::HandlePacket(const protocol::DisconnectPacket* packet) {
closeConnection();
}
@@ -145,7 +145,7 @@ void ServerConnexion::initConnection() {
}
}
void ServerConnexion::HandlePacket(protocol::PlaceTowerPacket* packet) {
void ServerConnexion::HandlePacket(const protocol::PlaceTowerPacket* packet) {
game::TowerType towerType = packet->getTowerType();
const game::TowerInfo& towerInfo = game::getTowerInfo(towerType);
server::ServerWorld* world = m_Server->getGame().getServerWorld();
@@ -164,7 +164,7 @@ void ServerConnexion::HandlePacket(protocol::PlaceTowerPacket* packet) {
m_Server->broadcastPacket(&addTowerPacket);
}
void ServerConnexion::HandlePacket(protocol::SendMobsPacket* packet) {
void ServerConnexion::HandlePacket(const protocol::SendMobsPacket* packet) {
const std::vector<protocol::MobSend>& mobSent = packet->getMobSends();
//TODO: verify the packet
@@ -174,7 +174,7 @@ void ServerConnexion::HandlePacket(protocol::SendMobsPacket* packet) {
}
}
void ServerConnexion::HandlePacket(protocol::UpgradeTowerPacket* packet){
void ServerConnexion::HandlePacket(const protocol::UpgradeTowerPacket* packet){
//TODO: verify the packet
m_Server->broadcastPacket(packet);