Persson-dev/Simple-Protocol-Lib
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

simplify dispatcher
All checks were successful
Linux arm64 / Build (push) Successful in 14s
Details

Browse Source
This commit is contained in:
Simon Pribylski
2025-03-03 11:00:36 +01:00
parent 6466e4bc45
commit c46c5bed6f
1 changed files with 3 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
include/sp/protocol/message/MessageDispatcherImpl.inl
View File

@@ -2,18 +2,14 @@
template <typename MessageIdType, typename MessageBase, typename MessageHandler> template <typename MessageIdType, typename MessageBase, typename MessageHandler>
void MessageDispatcher<MessageIdType, MessageBase, MessageHandler>::RegisterHandler(MessageIdType a_MessageType, MessageHandler* a_Handler) { void MessageDispatcher<MessageIdType, MessageBase, MessageHandler>::RegisterHandler(MessageIdType a_MessageType, MessageHandler* a_Handler) {
auto found = std::find_if(m_Handlers[a_MessageType].begin(), m_Handlers[a_MessageType].end(), [&a_Handler](const MessageHandler* handler){ auto found = std::find(m_Handlers[a_MessageType].begin(), m_Handlers[a_MessageType].end(), a_Handler);
return a_Handler == handler;
});
if (found == m_Handlers[a_MessageType].end()) if (found == m_Handlers[a_MessageType].end())
m_Handlers[a_MessageType].push_back(a_Handler); m_Handlers[a_MessageType].push_back(a_Handler);
} }
template <typename MessageIdType, typename MessageBase, typename MessageHandler> template <typename MessageIdType, typename MessageBase, typename MessageHandler>
void MessageDispatcher<MessageIdType, MessageBase, MessageHandler>::UnregisterHandler(MessageIdType a_MessageType, MessageHandler* a_Handler) { void MessageDispatcher<MessageIdType, MessageBase, MessageHandler>::UnregisterHandler(MessageIdType a_MessageType, MessageHandler* a_Handler) {
auto found = std::find_if(m_Handlers[a_MessageType].begin(), m_Handlers[a_MessageType].end(), [&a_Handler](const MessageHandler* handler){ auto found = std::find(m_Handlers[a_MessageType].begin(), m_Handlers[a_MessageType].end(), a_Handler);
return a_Handler == handler;
});
if (found != m_Handlers[a_MessageType].end()) if (found != m_Handlers[a_MessageType].end())
m_Handlers[a_MessageType].erase(found); m_Handlers[a_MessageType].erase(found);
} }
@@ -26,13 +22,7 @@ void MessageDispatcher<MessageIdType, MessageBase, MessageHandler>::UnregisterHa
MessageIdType type = pair.first; MessageIdType type = pair.first;
auto it = std::find_if(pair.second.begin(), pair.second.end(), [&a_Handler](MessageHandler* handler){ pair.second.erase(std::remove(pair.second.begin(), pair.second.end(), a_Handler), pair.second.end());
return handler == a_Handler;
});
if (it != pair.second.end())
pair.second.erase(it);
} }
} }