From 2149172b41e7875fcc3b3b018edbd7acb72ac521 Mon Sep 17 00:00:00 2001 From: Persson-dev Date: Fri, 18 Jul 2025 16:19:12 +0200 Subject: [PATCH] redundant template parameter --- include/sp/io/MessageStream.h | 1 + include/sp/protocol/ConcreteMessage.h | 10 ++++++---- test/test_message.cpp | 2 +- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/include/sp/io/MessageStream.h b/include/sp/io/MessageStream.h index 3aea568..2c0d632 100644 --- a/include/sp/io/MessageStream.h +++ b/include/sp/io/MessageStream.h @@ -4,6 +4,7 @@ #include #include #include +#include namespace sp { diff --git a/include/sp/protocol/ConcreteMessage.h b/include/sp/protocol/ConcreteMessage.h index f1a4960..f9cf5a7 100644 --- a/include/sp/protocol/ConcreteMessage.h +++ b/include/sp/protocol/ConcreteMessage.h @@ -5,21 +5,23 @@ namespace sp { -template -class ConcreteMessage : public MessageBase { +template +class ConcreteMessage : public MessageBase { public: using DataType = TData; + using MessageIdType = typename MessageBase::MessageIdType; + using HandlerType = typename MessageBase::HandlerType; template ConcreteMessage(const T&... args) : m_Data{args...} {} virtual ~ConcreteMessage() {} - virtual TMessageID GetId() const override { + virtual MessageIdType GetId() const override { return ID; } - virtual void Dispatch(THandler& handler) const override { + virtual void Dispatch(HandlerType& handler) const override { handler.Handle(static_cast(m_Data)); } diff --git a/test/test_message.cpp b/test/test_message.cpp index f16993a..7602ceb 100644 --- a/test/test_message.cpp +++ b/test/test_message.cpp @@ -19,7 +19,7 @@ class PacketHandler; using PacketBase = sp::MessageBase; template -using Message = sp::ConcreteMessage; +using Message = sp::ConcreteMessage; struct KeepAlivePacket { sp::BitField one;