refactor server room operations

This commit is contained in:
2025-03-01 13:06:55 +01:00
parent 63ec7b3aaa
commit 0533c16cf2
2 changed files with 28 additions and 42 deletions

View File

@@ -3,7 +3,6 @@ package server;
import java.io.IOException;
import java.net.DatagramSocket;
import java.net.InetSocketAddress;
import java.net.SocketException;
import network.SocketWriter;
import network.protocol.Packet;
@@ -48,32 +47,20 @@ public class ServerConnexion implements PacketVisitor {
@Override
public void visitPacket(CreateRoomPacket packet) {
try {
server.createRoom(packet.getRoomName(), this);
sendPacket(new ServerResponsePacket(Response.RoomCreated));
} catch (SocketException e) {
sendPacket(new ServerResponsePacket(Response.RoomNotCreated));
}
boolean created = server.createRoom(packet.getRoomName(), this);
sendPacket(new ServerResponsePacket(created ? Response.RoomCreated : Response.RoomNotCreated));
}
@Override
public void visitPacket(JoinRoomPacket packet) {
try {
server.joinRoom(packet.getRoomName(), this);
sendPacket(new ServerResponsePacket(Response.RoomJoined));
} catch (SocketException e) {
sendPacket(new ServerResponsePacket(Response.RoomNotJoined));
}
boolean joined = server.joinRoom(packet.getRoomName(), this);
sendPacket(new ServerResponsePacket(joined ? Response.RoomJoined : Response.RoomNotJoined));
}
@Override
public void visitPacket(LeaveRoomPacket packet) {
try {
server.leaveRoom(this);
sendPacket(new ServerResponsePacket(Response.RoomLeft));
} catch (SocketException e) {
sendPacket(new ServerResponsePacket(Response.RoomNotLeft));
}
boolean left = server.leaveRoom(this);
sendPacket(new ServerResponsePacket(left ? Response.RoomLeft : Response.RoomNotLeft));
}
@Override
@@ -95,11 +82,8 @@ public class ServerConnexion implements PacketVisitor {
@Override
public void visitPacket(SendChatMessagePacket packet) {
try {
server.sendToRoom(this, packet);
} catch (SocketException e) {
sendPacket(new ServerResponsePacket(Response.MessageNotSent));
}
boolean messageSent = server.sendToRoom(this, packet);
sendPacket(new ServerResponsePacket(messageSent ? Response.MessageSent : Response.MessageNotSent));
}
@Override